Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nss_wrapper-libs only with smaller footprint #403

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

hhorak
Copy link
Member

@hhorak hhorak commented Aug 21, 2023

No description provided.

@hhorak hhorak marked this pull request as draft August 21, 2023 18:30
@hhorak
Copy link
Member Author

hhorak commented Aug 21, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Aug 21, 2023

It would be better to merge #400 before this, to not cause unnecessary conflicts in #400 (which is hard to rebase due to mv/cp combination).

@hhorak
Copy link
Member Author

hhorak commented Aug 22, 2023

Tests fail on fastify, which is reported in #391

@hhorak hhorak marked this pull request as ready for review August 22, 2023 18:02
@hhorak hhorak changed the title Use nss_wrapper-libs only with smaller footprint [merge after #400] Use nss_wrapper-libs only with smaller footprint Aug 22, 2023
@phracek
Copy link
Member

phracek commented Sep 12, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Sep 12, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Sep 12, 2023

rebased, let's see whether it still works

@hhorak hhorak requested a review from phracek September 12, 2023 15:51
@hhorak hhorak changed the title [merge after #400] Use nss_wrapper-libs only with smaller footprint Use nss_wrapper-libs only with smaller footprint Sep 12, 2023
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phracek
Copy link
Member

phracek commented Sep 13, 2023

@hhorak I guess we need to build also nodejs-20 for nodejs-20-minimal

See logs from RHEL8:

[master (root-commit) e5e36a5] Sample commit
 5 files changed, 130 insertions(+)
 create mode 100644 README.md
 create mode 100644 iisnode.yml
 create mode 100644 package.json
 create mode 100644 server.js
 create mode 100644 web.config
Testing the production image build
Image ubi8/nodejs-20 not found, trying to pull ubi8/nodejs-20 from registry
Resolving "ubi8/nodejs-20" using unqualified-search registries (/etc/containers/registries.conf)
Trying to pull registry.access.redhat.com/ubi8/nodejs-20:latest...
Trying to pull registry.redhat.io/ubi8/nodejs-20:latest...
Trying to pull docker.io/ubi8/nodejs-20:latest...

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member

phracek commented Sep 14, 2023

rebased

[test]

@hhorak hhorak merged commit 86a8844 into sclorg:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants